Iframe: scale html instead of iframe el for zoom out #59334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +64 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
MaggieCabrera
approved these changes
Feb 24, 2024
|
Very nice! |
priethor
added
the
[Feature] Site Editor
t-hamano
reviewed
Feb 25, 2024
| transition: all 0.3s; | ||
| background-color: $gray-300; |
There was a problem hiding this comment.
This background color appears to affect the entire editor canvas. See #59348
There was a problem hiding this comment.
Yes, we'll have to only apply it for zoom out
This was referenced Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Basically reverts #47004, but instead of using the body element, use the html element so we don't clash with margins and backgrounds from themes too much.
Why?
To make vh units work
How?
Testing Instructions
Enable the zoom out mode experiment. @MaggieCabrera do you have testing instructions for a block using 100vh?
Also test that device previews are still scrollable.
With TT4 active:
Testing Instructions for Keyboard
Screenshots or screencast