Upgrade Playwright to v1.42 #59339
Merged
Upgrade Playwright to v1.42 #59339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
the
[Type] Automated Testing
Mamaduka
requested review from
gziolo,
ntwb,
nerrad,
ajitbohra and
ryanwelcher
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Mamaduka
commented
Feb 24, 2024
Comment on lines
+30
to
+32
| const result = spawn( 'npx', [ 'playwright', 'install' ], { | ||
| stdio: 'inherit', | ||
| } ); |
There was a problem hiding this comment.
Mamaduka
requested review from
WunderBart and
kevin940726
and removed request for
ntwb,
ajitbohra,
ryanwelcher and
nerrad
|
Size Change: 0 B Total Size: 1.71 MB ℹ️ View Unchanged
|
|
Flaky tests detected in 7e48d59. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/8030483255
|
Mamaduka
commented
Feb 24, 2024
| await page.keyboard.down( 'Shift' ); | ||
| await page.keyboard.press( 'ArrowUp' ); | ||
| await page.keyboard.up( 'Shift' ); | ||
| await pageUtils.pressKeys( 'primary+a', { times: 2 } ); |
There was a problem hiding this comment.
I'm unsure if this is a bug in core or just an e2e test quirk, but when using pageUtils.pressKeys( 'shift+ArrowUp' ) block toolbar isn't visible.
I can't reproduce the issue when testing manually.
Screenshot
Mamaduka
force-pushed
the
update/playwright-latest
branch
from
744b3f4
to
65fa0fe
Compare
|
I see a problem with artifacts - https://github.com/WordPress/gutenberg/actions/runs/8044664244?pr=59339. We might need to update the configuration. Update: It might be unrelated. I see same error on other PRs - https://github.com/WordPress/gutenberg/actions/runs/8040401372?pr=59350 Screenshot
|
|
They just released v1.42.0, might be good to update to that as well 😆? |
Mamaduka
force-pushed
the
update/playwright-latest
branch
from
65fa0fe
to
f162e7f
Compare
|
I updated Playwright to the latest release. Update: The e2e test failures seem to come from the update. I am unsure what has changed; I will look into it later. |
|
It looks like there's a regression with Playwright v1.42 and chained locators (which the project uses heavily). Reported it upstream - microsoft/playwright#29760. |
Mamaduka
force-pushed
the
update/playwright-latest
branch
from
e0cdd87
to
9c47039
Compare
Mamaduka
force-pushed
the
update/playwright-latest
branch
from
9c47039
to
ecf9ecf
Compare
|
Okay, I rebased on more time and will merge if the checks are green. |
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Mar 27, 2024
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: kevin940726 <kevin940726@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Upgrade Playwright to v1.41.2
What's new?
https://github.com/microsoft/playwright/releases/tag/v1.41.0
https://github.com/microsoft/playwright/releases/tag/v1.42.0
Testing Instructions