Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Gutenberg font face tests #59402

Merged
merged 1 commit into from
Feb 27, 2024
Merged

Conversation

matiasbenedetto
Copy link
Contributor

What?

Remove Gutenberg font face tests.

Why?

The tests that no longer test the code in Gutenberg but the code from core because the classes being tested are not loaded from Gutenberg but from core

How?

removing the test files.

…de from core because the classes being tested are not loaded from gutenberg but from core
Copy link

github-actions bot commented Feb 27, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: matiasbenedetto <mmaattiiaass@git.wordpress.org>
Co-authored-by: getdave <get_dave@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@matiasbenedetto matiasbenedetto added [Type] Code Quality Issues or PRs that relate to code quality [Feature] Typography Font and typography-related issues and PRs labels Feb 27, 2024
@getdave getdave changed the title Remove Gutenberg font fae tests Remove Gutenberg font face tests Feb 27, 2024
Copy link
Contributor

@getdave getdave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@youknowriad youknowriad merged commit 8efca84 into trunk Feb 27, 2024
60 of 63 checks passed
@youknowriad youknowriad deleted the remove-font-face-resolver-tests branch February 27, 2024 13:28
@github-actions github-actions bot added this to the Gutenberg 17.9 milestone Feb 27, 2024
getdave added a commit that referenced this pull request Feb 27, 2024
…de from core because the classes being tested are not loaded from gutenberg but from core (#59402)

Co-authored-by: matiasbenedetto <mmaattiiaass@git.wordpress.org>
Co-authored-by: getdave <get_dave@git.wordpress.org>
@getdave
Copy link
Contributor

getdave commented Feb 27, 2024

I just manually cherry-picked this PR to the cherry-pick-wp-6-5-beta-3 branch to get it included in the next release.

I did this to get the tests passing on that PR.

getdave added a commit that referenced this pull request Feb 27, 2024
…de from core because the classes being tested are not loaded from gutenberg but from core (#59402)

Co-authored-by: matiasbenedetto <mmaattiiaass@git.wordpress.org>
Co-authored-by: getdave <get_dave@git.wordpress.org>
@creativecoder creativecoder added the Backport to Gutenberg RC Pull request that needs to be backported to a Gutenberg release candidate (RC) label Feb 27, 2024
@creativecoder
Copy link
Contributor

It looks like this is also needed for the release/17.8 branch, as the same phpunit tests are failing there. I've added the Backport to Gutenberg RC label.

@creativecoder
Copy link
Contributor

I just cherry-picked this PR to the release/17.8 branch to get it included in the next release: de472fd

creativecoder pushed a commit that referenced this pull request Feb 27, 2024
…de from core because the classes being tested are not loaded from gutenberg but from core (#59402)

Co-authored-by: matiasbenedetto <mmaattiiaass@git.wordpress.org>
Co-authored-by: getdave <get_dave@git.wordpress.org>
@creativecoder creativecoder removed the Backport to Gutenberg RC Pull request that needs to be backported to a Gutenberg release candidate (RC) label Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Typography Font and typography-related issues and PRs [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants