-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Gutenberg font face tests #59402
Conversation
…de from core because the classes being tested are not loaded from gutenberg but from core
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
…de from core because the classes being tested are not loaded from gutenberg but from core (#59402) Co-authored-by: matiasbenedetto <mmaattiiaass@git.wordpress.org> Co-authored-by: getdave <get_dave@git.wordpress.org>
I just manually cherry-picked this PR to the cherry-pick-wp-6-5-beta-3 branch to get it included in the next release. I did this to get the tests passing on that PR. |
…de from core because the classes being tested are not loaded from gutenberg but from core (#59402) Co-authored-by: matiasbenedetto <mmaattiiaass@git.wordpress.org> Co-authored-by: getdave <get_dave@git.wordpress.org>
It looks like this is also needed for the |
I just cherry-picked this PR to the release/17.8 branch to get it included in the next release: de472fd |
…de from core because the classes being tested are not loaded from gutenberg but from core (#59402) Co-authored-by: matiasbenedetto <mmaattiiaass@git.wordpress.org> Co-authored-by: getdave <get_dave@git.wordpress.org>
What?
Remove Gutenberg font face tests.
Why?
The tests that no longer test the code in Gutenberg but the code from core because the classes being tested are not loaded from Gutenberg but from core
How?
removing the test files.