Mobile Release v1.114.0 #59461
Merged
Mobile Release v1.114.0 #59461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SiobhyB
added
[Type] Build Tooling
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +105 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
4 tasks
geriux
reviewed
Feb 29, 2024
| "-Wl", | ||
| "-ld_classic", | ||
| ); | ||
| OTHER_LDFLAGS = "$(inherited)"; |
There was a problem hiding this comment.
Do we know why this change is showing up for the release? It looks like it's also there in the Gutenberg Mobile PR.
There was a problem hiding this comment.
I see some of the changes that happened in this PR are being reverted, but I'm not sure why.
I added the removed lines back locally then ran bundle exec pod install --repo-update, and they were removed again with the following warning:
[!] The `GutenbergDemo [Debug]` target overrides the `LIBRARY_SEARCH_PATHS` build setting defined in `Pods/Target Support Files/Pods-GutenbergDemo/Pods-GutenbergDemo.debug.xcconfig'. This can lead to problems with the CocoaPods installation
- Use the `$(inherited)` flag, or
- Remove the build settings from the target.
[!] The `GutenbergDemo [Release]` target overrides the `LIBRARY_SEARCH_PATHS` build setting defined in `Pods/Target Support Files/Pods-GutenbergDemo/Pods-GutenbergDemo.release.xcconfig'. This can lead to problems with the CocoaPods installation
- Use the `$(inherited)` flag, or
- Remove the build settings from the target.
So, it seems like these changes may be correct. @fluiddot, does this seems right to you, as the author of the original changes?
There was a problem hiding this comment.
The changes in the Xcode project are related to this commit from React Native. AFAIK it's a patch for Xcode 15.
There was a problem hiding this comment.
@SiobhyB Not sure why they are getting reverted, I can try to install the pods locally and see if I get the same modifications.
There was a problem hiding this comment.
@SiobhyB Are you using Xcode 15? If not, maybe that could be the reason why they are being removed?
There was a problem hiding this comment.
Huh, I'm on Xcode 15.2. 🤔 Are they not removed when you run bundle exec pod install --repo-update locally?
There was a problem hiding this comment.
Actually, when I ran xcodebuild -version in the command line, I get 13.4.1. I'll figure out how to update that now...
There was a problem hiding this comment.
I'm running bundle exec pod install --repo-update locally and the Xcode project remains unmodified. @SiobhyB I wonder what's the difference in our setup. Could you check the React Native version installed in your local environment?
You can quickly check the version by running cat node_modules/react-native/package.json | jq '.version' in Gutenberg.
There was a problem hiding this comment.
Actually, when I ran xcodebuild -version in the command line, I get 13.4.1. I'll update now...
That might be the issue, yeah try changing the Xcode selection to use 15.2
I've run bundle exec pod install --repo-update and I don't see any changes locally.
There was a problem hiding this comment.
fluiddot
added a commit
that referenced
this pull request
Mar 11, 2024
* Release script: Update react-native-editor version to 1.114.0 * Release script: Update CHANGELOG for version 1.114.0 * Release script: Update podfile * fix: Restore Xcode 15 patch See: #59461 * Release script: Update react-native-editor version to 1.114.1 * Release script: Update CHANGELOG for version 1.114.1 * Release script: Update podfile * [RNMobile] Fix issue in synced patterns related to missing `getRichTextValues` private API (#59632) * Export `getRichTextValues` private API This module is used in the footnotes logic, which is triggered on changes in the content of a synced pattern. * Add integration test to cover issue's case --------- Co-authored-by: Siobhan <siobhan@automattic.com>
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Mar 27, 2024
* Release script: Update react-native-editor version to 1.114.0 * Release script: Update CHANGELOG for version 1.114.0 * Release script: Update podfile * fix: Restore Xcode 15 patch See: WordPress#59461 * Release script: Update react-native-editor version to 1.114.1 * Release script: Update CHANGELOG for version 1.114.1 * Release script: Update podfile * [RNMobile] Fix issue in synced patterns related to missing `getRichTextValues` private API (WordPress#59632) * Export `getRichTextValues` private API This module is used in the footnotes logic, which is triggered on changes in the content of a synced pattern. * Add integration test to cover issue's case --------- Co-authored-by: Siobhan <siobhan@automattic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Release 1.114.0 of the react-native-editor and Gutenberg-Mobile.
Gutenberg-Mobile PR: wordpress-mobile/gutenberg-mobile#6687