Global Styles: Create a style preview component #59498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scruffian
added
the
Global Styles
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
scruffian
commented
Mar 1, 2024
| const noop = () => {}; | ||
|
|
||
| const PreviewWrapper = ( { | ||
| firstFrame = noop, |
There was a problem hiding this comment.
The main consideration here IMO is whether it makes sense to pass three different components as three different props.
There was a problem hiding this comment.
Could it be an array of frames? e.g., frames={ [ ... ] }
There was a problem hiding this comment.
Or child components?
<PreviewWrapper>
<>
<FirstFrame />
<SecondFrame />
<>
</PreviewWrapper>There was a problem hiding this comment.
I did it with child components
|
Size Change: -996 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
scruffian
force-pushed
the
refactor/global-styles-previews
branch
from
e104269 to
3ed9264
Compare
ramonjd
reviewed
Mar 4, 2024
| blockEditorPrivateApis | ||
| ); | ||
|
|
||
| const firstFrameVariants = { |
There was a problem hiding this comment.
If the props were changed from firstFrame, etc.. to an array, or they're rendered as children, do you think it's reasonable for these variants to be passed as part of the frame components?
Might make it neater in the render block below (inside <motion.div initial="start" ... />)?
Then it would be able to accommodate one or more frames. 🤷🏻
ramonjd
reviewed
Mar 4, 2024
There was a problem hiding this comment.
This PR is working in the site editor as described. Thank you!
I think maybe it might abstract things further to have PreviewWrapper accept children or an array of frames. It might result in a bit of duplicate code, e.g., the frame variants, but would be more flexible for other uses?
packages/edit-site/src/components/global-styles/preview-wrapper.js
Outdated
Show resolved
Hide resolved
packages/edit-site/src/components/global-styles/preview-highlighted-colors.js
Outdated
Show resolved
Hide resolved
scruffian
changed the title
rafctor to three frames
scruffian
force-pushed
the
refactor/global-styles-previews
branch
from
3ed9264 to
621088c
Compare
scruffian
force-pushed
the
refactor/global-styles-previews
branch
from
f127af7 to
abdb873
Compare
|
Thanks for the review, I think this is ready for another look. |
ramonjd
approved these changes
Mar 5, 2024
ramonjd
reviewed
Mar 5, 2024
packages/edit-site/src/components/global-styles/highlighted-colors.js
Outdated
Show resolved
Hide resolved
…lors.js Co-authored-by: Ramon <ramonjd@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This is a followup to #56622, which tries to refactor some of the duplicate code to be shared between components.
Why?
Sharing code between different components helps us to keep behaviours consistent across the product.
How?
PreviewWrapper has 3 frames but they don't all need to be implemented.
The next step here would be to explore using the PreviewWrapper component to display Typography previews too, but I didn't want to go too far in one PR.
Testing Instructions
Screenshots or screencast