Add pattern title in create modal in post editor #59550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
[Type] Regression
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -758 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
youknowriad
reviewed
Mar 4, 2024
|
I actually now observed that this behaves very weird when using arrow keys to move the cursor to the content.. Seems relate to this comment
(It's probably margin present on the appender that disappears when replaced with the paragraph.) |
ntsekouras
force-pushed
the
show-pattern-title-in-editor
branch
from
aa338ec
to
23ecaf0
Compare
|
I'm a little anxious about putting the title on the canvas, for a couple of reasons:
We have this menu in the template part Inspector: 
Could we do something similar here, with a 'Rename' action that opens the modal? |
The context here is a 6.5 hotfix for being able to change the title at all, when using the classic theme pattern flow. My hope was do do a little light styling so it works well, but ultimately find a new interface for editing the title of any entity, exactly as you suggest, perhaps with a rename action in the ellipsis menu in the inspector. But that won't make it to 6.5. What do you think? |
|
Maybe adding the "title" to the modal should be enough for 6.5 without adding it to the canvas. |
ntsekouras
force-pushed
the
show-pattern-title-in-editor
branch
from
23ecaf0
to
bff3c2a
Compare
ntsekouras
changed the title
|
Is there any benefit in sending folks to |
|
I created a separate PR for the appender shift #59582 What's next for this one? |
|
Should we rename this component to clarify its purpose (it's not just about the sync status anymore) |
Perhaps the old screen was used because the Site Editor pattern screens need more testing with classic themes? |
ntsekouras
commented
Mar 5, 2024
|
|
||
| const { ReusableBlocksRenameHint } = unlock( blockEditorPrivateApis ); | ||
|
|
||
| export default function InitPatternModal() { |
There was a problem hiding this comment.
I moved this in edit-post since this is the only place is used. Additionally we should probably look into how we can consolidate this one with CreatePatternModal from patterns package. This could be in a follow up though and not a block for this PR to land for 6.5
Can't classic theme users access the Patterns page in the Site Editor? In 6.5 this is a data view with bulk actions and so on, so there doesn't seem to be a lot of value in sending folks to this wp-admin list view at all. As mentioned in #58210 the only task you can perform there – and not in the data view – is bulk editing categories. I don't know that alone makes this view worthy of surfacing so prominently? |
I think the problem is "in 6.5". That was the goal but it didn't happen because of some Core API that was needed that I didn't understand. @t-hamano should know. |
In WP6.5, classic themes can access the Patterns page in the Site Editor. However, this is a preliminary step for the Gutenberg plugin to maintain compatibility with older WP versions, and the classic theme is actually expected to access the old patterns page ( If the classic theme is enabled, there will be no menu or link to access the Site Editor's Pattern page, and users should not be able to access it unless they enter the URL directly. This comment also mentions detailed specifications for WP6.5 and a future roadmap. |
youknowriad
added
the
Backport to WP 6.7 Beta/RC
youknowriad
approved these changes
Mar 6, 2024
|
This PR is intended for inclusion in WP 6.5 during the RC phase as it fixes a bug (identified during RC) that it was not possible to set a title for Pattern created via when going through the pattern creation flow in |
getdave
pushed a commit
that referenced
this pull request
Mar 11, 2024
Co-authored-by: ntsekouras <ntsekouras@git.wordpress.org> Co-authored-by: youknowriad <youknowriad@git.wordpress.org> Co-authored-by: jameskoster <jameskoster@git.wordpress.org> Co-authored-by: jasmussen <joen@git.wordpress.org> Co-authored-by: carolinan <poena@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org>
|
I just cherry-picked this PR to the pick/wp-65-rc-2 branch to get it included in the next release: 4e8563f |
getdave
added
Backported to WP Core
getdave
pushed a commit
that referenced
this pull request
Mar 12, 2024
Co-authored-by: ntsekouras <ntsekouras@git.wordpress.org> Co-authored-by: youknowriad <youknowriad@git.wordpress.org> Co-authored-by: jameskoster <jameskoster@git.wordpress.org> Co-authored-by: jasmussen <joen@git.wordpress.org> Co-authored-by: carolinan <poena@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Partially addresses(for 6.5): #59511
There are many discussions in the issues about how to handle this properly, but it's clear we need to do the minimum(add the ability to change the title) for 6.5.
In my initial commit, I'm showing the title in the create modal in post editor.