Pages data view: Make 'View' button open a new tab #59554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameskoster
added
[Type] Enhancement
|
Size Change: +13 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
As noted, I'd support either direction forward, and favor consistency here! |
|
Hah, I forgot about that conversation :) My opinion hasn't really changed – if we're going to use this icon then it feels more intuitive (to me) that the link opens in a new tab. |
|
I think it's OK to merge this PR, but is there any consistency that will be lost with this change or anything we should change in a follow-up? |
|
The main inconsistency would be the behavior of this button, and the 'View' link in wp-admin post type lists. They're equivalent buttons, but the latter does not open a new tab. |
t-hamano
approved these changes
Mar 4, 2024
There was a problem hiding this comment.
I think this change makes sense given the context within the Site Editor and Block Editor. Perhaps in the future, if post type lists become React-based, opening in a new tab will become the default. I approve this PR, but if @jasmussen has any concerns, please let us know.
|
Given that RC1 is today, I'm removing this from 6.5 as non essential. |
youknowriad
removed
the
Backport to WP 6.7 Beta/RC
|
Since this will now be a 6.6 thing let's merge and see how it goes. It's a small change that's easily reverted if needed. |
29 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Update the 'View' button to open a new tab.
Why?
How?
Testing Instructions