Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation Block: Remove unnecessary @param annotation #59559

Merged
merged 1 commit into from
Mar 5, 2024

Conversation

t-hamano
Copy link
Contributor

@t-hamano t-hamano commented Mar 4, 2024

Found this while investigating #59516

What?

This PR removes unnecessary annotation in the get_nav_element_directives method of the WP_Navigation_Block_Renderer class.

Testing Instructions

No impact on the code.

P.S. Does this need to be WP6.5 backported?

@t-hamano t-hamano added the [Type] Code Quality Issues or PRs that relate to code quality label Mar 4, 2024
@t-hamano t-hamano self-assigned this Mar 4, 2024
@t-hamano t-hamano added the [Block] Navigation Affects the Navigation Block label Mar 4, 2024
@t-hamano t-hamano requested review from ockham and scruffian March 4, 2024 15:43
@t-hamano t-hamano marked this pull request as ready for review March 4, 2024 15:44
@t-hamano t-hamano requested a review from ajitbohra as a code owner March 4, 2024 15:44
Copy link

github-actions bot commented Mar 4, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Co-authored-by: ockham <bernhard-reiter@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link
Contributor

@ockham ockham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@t-hamano t-hamano merged commit 64fb8dd into trunk Mar 5, 2024
67 checks passed
@t-hamano t-hamano deleted the quality/navigation-remove-unnecessary-annotation branch March 5, 2024 00:47
@github-actions github-actions bot added this to the Gutenberg 17.9 milestone Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Navigation Affects the Navigation Block [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants