Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix media replace url which overlaps edit icon #59808

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from

Conversation

DamChtlv
Copy link

@DamChtlv DamChtlv commented Mar 13, 2024

What?

This PR fix the media url which overlaps edit icon when the url is too long which makes it hard to click.

image

Why?

Fix this issue: #59807

How?

By setting a text overflow ellipsis on this url to prevent the issue.

Testing Instructions

  1. Go in the editor (in any context: page edition, template edition...)
  2. Add any media block (ex: image, video...)
  3. Click on the media block
  4. Click on "Insert a url" inside this block
  5. Add a long url and save
  6. Click on the video block and click on "Replace" in the toolbar
  7. See the result

Testing Instructions for Keyboard

Screenshots or screencast

Before

image

After

image

@DamChtlv DamChtlv requested a review from ellatrix as a code owner March 13, 2024 00:31
Copy link

github-actions bot commented Mar 13, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: DamChtlv <damchtlv@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Mar 13, 2024
Copy link

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @DamChtlv! In case you missed it, we'd love to have you join us in our Slack community.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@DamChtlv DamChtlv changed the title Fix media replace url to overlap edit icon Fix media replace url which overlaps edit icon Mar 13, 2024
@DamChtlv
Copy link
Author

Updated my WP profile to link my github account :)

@t-hamano t-hamano added [Type] Bug An existing feature does not function as intended [Feature] Media Anything that impacts the experience of managing media labels Mar 13, 2024
@t-hamano t-hamano self-requested a review March 13, 2024 11:33
Copy link
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the report! As mentioned in this comment, I think it would be better to first check what kind of URL this problem occurs at.

@DamChtlv
Copy link
Author

Thanks for the report! As mentioned in this comment, I think it would be better to first check what kind of URL this problem occurs at.

Replied in the issue also but I have used url without file extension at the end (some CDN or other services have that kind of urls)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Media Anything that impacts the experience of managing media First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants