-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix media replace url which overlaps edit icon #59808
base: trunk
Are you sure you want to change the base?
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @DamChtlv! In case you missed it, we'd love to have you join us in our Slack community. If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information. |
Updated my WP profile to link my github account :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the report! As mentioned in this comment, I think it would be better to first check what kind of URL this problem occurs at.
Replied in the issue also but I have used url without file extension at the end (some CDN or other services have that kind of urls) |
What?
This PR fix the media url which overlaps edit icon when the url is too long which makes it hard to click.
Why?
Fix this issue: #59807
How?
By setting a text overflow ellipsis on this url to prevent the issue.
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast
Before
After