DataViews: make list layout stable #59858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oandregal
added
[Type] Enhancement
|
Size Change: -82 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
oandregal
force-pushed
the
update/dataviews-list-layout-stable
branch
from
7639e6c
to
0e8954a
Compare
oandregal
requested review from
mcsf,
jameskoster,
SaxonF,
jorgefilipecosta and
ntsekouras
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
This was referenced Mar 14, 2024
youknowriad
approved these changes
Mar 15, 2024
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Mar 27, 2024
Co-authored-by: oandregal <oandregal@git.wordpress.org> Co-authored-by: youknowriad <youknowriad@git.wordpress.org>
29 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #55083
Related #59659
What?
Makes the
listlayout stable, so it is available without the "admin views" experiment enabled.Why?
It is to be used as the index for some of the types (pages). While there's still issues to iron out, it's quite solid.
How?
Testing Instructions
Disable the "admin views" experiment and verify that the
listlayout is available for Pages, Templates, and Parts. It should work in all the flows.Notes
Note: the commit d7bddee represents the #59792 but squashed. Trying to assess whether the performance test failure that happens over there is real.