-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
List Item: Add color support #59892
List Item: Add color support #59892
Conversation
Still keen on this? Happy to review if you rebase. |
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
480d18b
to
1dab1c0
Compare
Thanks for the nudge, it's been rather low down the priority list 😅 I've rebased this and also updated the use of the deprecated |
When I set a List Item colour in Global Styles I wasn't able to see that colour show up on the frontend. Kapture.2024-07-03.at.11.23.05.mp4 |
1dab1c0
to
6e9c69d
Compare
Thanks for catching that @noisysocks 👍 I'd messed up placing the Screen.Recording.2024-07-03.at.3.53.54.PM.mp4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wunderbar
Co-authored-by: aaronrobertshaw <aaronrobertshaw@git.wordpress.org> Co-authored-by: noisysocks <noisysocks@git.wordpress.org> Co-authored-by: pitamdey <pitamdey@git.wordpress.org>
Fixes: #59854
What?
Adds color block support to the List Item block to match the parent List block.
Why?
The List Item block allows customizing typographic styles. This PR provides consistency for color styling and greater control for users.
How?
__experimentalSelector
to use the selectors API.Testing Instructions
Screenshots or screencast
Screen.Recording.2024-03-15.at.5.35.32.PM.mp4