Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use NPM workspaces #59933

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

yusuke-omae
Copy link

What?

Enable npm workspaces.

Why?

npm workspace can detect incorrect management of monorepo.
This PR is a follow-up to #48950 and #53426.

How?

Testing Instructions

Testing Instructions for Keyboard

Screenshots or screencast

Copy link

github-actions bot commented Mar 17, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: yusuke-omae <omaeyusuke@git.wordpress.org>
Co-authored-by: gziolo <gziolo@git.wordpress.org>
Co-authored-by: kevin940726 <kevin940726@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @yusuke-omae! In case you missed it, we'd love to have you join us in our Slack community.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Mar 17, 2024
@gziolo
Copy link
Member

gziolo commented Jun 13, 2024

@kevin940726, I see some Ci jobs failed. Do you remember what other changes were necessary to enable workspaces?

@gziolo gziolo added the [Type] Build Tooling Issues or PRs related to build tooling label Jun 13, 2024
@kevin940726
Copy link
Member

I don't recall exactly the parts needed, but I also don't remember having to change so many lines in package-lock.json 🤔. I think there might be something wrong there and maybe we could try regenerating them?

@gziolo
Copy link
Member

gziolo commented Jun 18, 2024

The difference was that the local packages were still listed as dependencies in the package.json in the old PR:

Screenshot 2024-06-18 at 09 18 04

I'm wondering how the changes proposed in this PR impact how dependencies get resolved. Do all of them get recognized as production or development dependencies? I also wonder what implications it has on how we scan licenses, as there is a more relaxed set of rules for dev dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Type] Build Tooling Issues or PRs related to build tooling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants