DataViews: add AND logic operators to filters #59953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
oandregal
added
[Type] Enhancement
5 tasks
|
The only use case where we could implement this is the Author filter for Templates & Parts. It doesn't make much sense there, so I haven't implemented it. |
|
Size Change: +90 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
26 tasks
|
I get a |
Ah, sorry, updated the issue description to use the filter names instead. The constants are not defined for the edit-site package because they are not in use. |
|
I went ahead with this to unblock the next iteration. Happy to update any post-merge feedback. |
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Mar 27, 2024
Co-authored-by: oandregal <oandregal@git.wordpress.org> Co-authored-by: jameskoster <jameskoster@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #55083
Related #55100
Follow-up to #59610
What?
Adds two new operators
isAllandisNotAllthat filters can use. They are not in use by default, as none of the current use cases (pages, patterns, templates, parts) needs it.Why?
We want to support this operation for future use cases (posts, media).
How?
Testing Instructions
Templates&Partsatpackages/edit-site/src/components/page-templates-template-parts/index.js, and declare these filters as supported for theAuthorfield:And that the filter's operator at this point is correct.