Revert shadow.defaultPresets default to true #60000
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trac ticket: https://core.trac.wordpress.org/ticket/60815
WP Dev PR: WordPress/wordpress-develop#6295
What?
Reverts the core
settings.shadow.defaultPresets
back totrue
.Why?
Fixes #59989
Themes should not change appearance with just a WP update. We have a migration mechanism for theme.json to allow for theme authors to change default values that should be used if we want to change a default.
All of the
default*
settings have beentrue
by default as they've been added, so this brings consistency to that again as well.How?
settings.shadow.defaultPresets
totrue
in lib/theme.json.array( 'shadow', 'defaultPresets' )
fromAPPEARANCE_TOOLS_OPT_INS
as it is no longer needed when we havetrue
by default.editor-shadow-presets
anddefault-shadow-presets
theme supports for classic themes to match how colors/gradients presets work.Testing Instructions
Block themes
Here is an example theme.json for testing that would override the default
natural
shadow with a red shadow to make the difference obvious.wp/6.4
trunk
wp/6.4
and this PR match.Classic themes
TODO: Finish writing testing scenarios.
Test disabling shadow presets.
Test custom shadow presets.
Test disabling default shadow presets.
Testing Instructions for Keyboard
N/A
Screenshots or screencast
Block themes
WP 6.4
Current 6.5 (
"defaultPresets": false
)This PR (
"defaultPresets": true
)Classic themes
TODO: Screenshots of UI for classic themes in each of the testing scenarios.