-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
theme.json schema: Add settings.color.caption definition #60017
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 LGTM
I believe this is correct and that this PR should be merged, but I got confused for a moment because I do not see a warning in Twenty Twenty-Four, |
@carolinan Sorry, there was a mistake in my explanation 😅 What I wanted to mention is the core (default) thme.json, not the TT4 theme.json. I mean, this file. https://github.com/WordPress/wordpress-develop/blob/trunk/src/wp-includes/theme.json |
…0017) * theme.json schema: Add settings.color.caption definition * Rebuild docs Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: ajitbohra <ajitbohra@git.wordpress.org> Co-authored-by: carolinan <poena@git.wordpress.org>
What?
This PR adds the missing
settings.color.caption
definition in the theme.json schema. This should also eliminate the warning that is occurring inTT4'sthe default theme.json.Testing Instructions
Create a JSON file like the one below locally and make sure the
settings.color.caption
property is allowed.Testing Instructions for Keyboard
Screenshots or screencast
Before
After