Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Mobile] Fixes Aztec IndexOutOfBoundsException #60107

Closed
wants to merge 1 commit into from
Closed

[Mobile] Fixes Aztec IndexOutOfBoundsException #60107

wants to merge 1 commit into from

Conversation

antonis
Copy link
Member

@antonis antonis commented Mar 22, 2024 •
edited
Loading

[DO NOT MERGE]

Fixes wordpress-mobile/WordPress-Android#20481

Related PRs:

What?

Adds exception handling in the Aztec Android editor for an edge case

Why?

This bug resulted in a crash on some occasions

How?

Testing Instructions

See wordpress-mobile/AztecEditor-Android#1078

Testing Instructions for Keyboard

The PR is mobile only and does not affect the UI

Screenshots or screencast

See wordpress-mobile/AztecEditor-Android#1078

@antonis antonis added [Type] Bug An existing feature does not function as intended Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) labels Mar 22, 2024
@antonis antonis changed the title Fixes Aztec IndexOutOfBoundsException [Mobile] Fixes Aztec IndexOutOfBoundsException Mar 22, 2024
This was referenced Mar 22, 2024
Merged
Merged
Merged
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 22, 2024 •
edited
Loading

Flaky tests detected in 4469fe7f9e09455644ea5d63a5efd90cbababdc8.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/8390231310
📝 Reported issues:

@antonis antonis marked this pull request as ready for review March 22, 2024 08:32
@antonis antonis requested a review from geriux March 22, 2024 08:33
geriux
geriux approved these changes Mar 22, 2024
View reviewed changes
Copy link
Member

@geriux geriux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved via wordpress-mobile/AztecEditor-Android#1078 (review)

Friendly reminder to update this to the Aztec tag once it is released 🚀

@geriux geriux force-pushed the fix/20481-charoutofbounds branch from 4469fe7 to e31d0a6 Compare March 22, 2024 13:29
@antonis antonis marked this pull request as draft March 22, 2024 13:42
@geriux geriux mentioned this pull request Mar 22, 2024
Merged
@antonis
Copy link
Member Author

antonis commented Mar 22, 2024 •
edited
Loading

Closing in favor of #60115
Due to the following persisting ci failure

Run WordPress/props-bot-action@trunk
Gathering contributor list.
Error: Request failed due to following response errors:
 - Could not resolve to a User with the login of 'sentry-io'.

@antonis antonis closed this Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geriux geriux geriux approved these changes

Assignees
No one assigned
Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

IndexOutOfBoundsException: charAt: X >= length X
2 participants
@antonis @geriux