-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Create block] Add new namespacePascalCase template variable. #60223
[Create block] Add new namespacePascalCase template variable. #60223
Conversation
…eSnakeCase that was incorrecly using the slug instead of the namespace.
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Size Change: 0 B Total Size: 1.72 MB ℹ️ View Unchanged
|
…ess#60223) * Add new template variable called namespacePascalCase and fix namespaceSnakeCase that was incorrecly using the slug instead of the namespace. * Use new namespacePascalCase template variable and remove some extraneous whitespace * Update changelog Co-authored-by: ryanwelcher <welcher@git.wordpress.org> Co-authored-by: justintadlock <greenshady@git.wordpress.org>
…ess#60223) * Add new template variable called namespacePascalCase and fix namespaceSnakeCase that was incorrecly using the slug instead of the namespace. * Use new namespacePascalCase template variable and remove some extraneous whitespace * Update changelog Co-authored-by: ryanwelcher <welcher@git.wordpress.org> Co-authored-by: justintadlock <greenshady@git.wordpress.org>
What?
This PR adds a new template variable called namespacePascalCase and fixes an issue with the existing namespaceSnakeCase variable incorrectly using the slug.
Why?
There is currently no pascal case version of the namespace but there is for the slug. Adding this in will allow template authors to create valid PHP namespaces and
@package
tags.The default templates use the {{namespace}} template variable to populate the
@package
tag in the plugin file(see here).If the namespace contains hypens as the default value does, then this will generate a package of
create-block
. Which is not a valid PHP namespace.What would be better is to have a pascalCase version that would create
CreateBlock
. This could then be combined with the pascal slug to create a full namespace for each block.CreateBlock\MyCustomBlock
. For those creating plugins with multiple blocks to use the same namespace, this will keep all of the blocks contained in the same namespace.Testing Instructions
node ./packages/create-block/index.js test-namespace
@package
in test-namespace.php is set toCreateBlock