Add bulk actions for block editing modes #60312
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajlende
added
[Type] Performance
|
Size Change: +114 B (0%) Total Size: 1.72 MB
ℹ️ View Unchanged
|
|
Did you try using |
I hadn't yet. And now that I have it seems the |
youknowriad
deleted the
add/block-editor-store-bulk-block-editing-mode-actions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Adds two new actions for bulk editing block editing modes.
setBlockEditingModeswhich takes an iterable (Array,Map, etc.) of client id and mode tuples to set.unsetBlockEditingModeswhich takes an interable of client ids to unset.Updates the places that could benefit from using the new actions.
Why?
In #59249 we were running into performance issues around setting block editing modes in a loop. Each action causes a
new Map()to be created which was causing memory thrashing and really bad performance when switching editing modes.@Mamaduka pointed out in #59249 (comment) that there were other places that could benefit from the change, so I've extracted this into a separate PR.
How?
Only creating one
new Map()for a full set of changes is much more friendly to the garbage collector.Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast