Media & Text: Hide the alt text option for featured images #60496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hides the TextareaControl for the alternative text if the block uses a featured image. Adds the alt attribute to the image tag on the front.
carolinan
added
[Type] Bug
|
Size Change: +1.95 kB (0%) Total Size: 1.73 MB
ℹ️ View Unchanged
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
t-hamano
reviewed
Apr 8, 2024
Co-authored-by: Aki Hamano <54422211+t-hamano@users.noreply.github.com>
|
Flaky tests detected in 995f864. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/8609560868
|
Replace featuredImageURL with useFeaturedImage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Hides the TextareaControl for the alternative text if the block uses a featured image.
Adds the alt attribute to the img tag on the front.
Closes #60023
Why?
The alt text option does not work correctly in the editor, it is problematic inside query loops, and the alt text is not output on the front. Please see the discussion in the linked issue.
How?
The PR:
Testing Instructions
With Gutenberg trunk:
Add three media & text blocks:
One with a video, one with a standard image, and one with a featured image. The featured image should not have an alt text in the media library.
Save.
Apply the PR.
Refresh the post and confirm that the PR does not cause any block validation errors with the existing blocks.
Select the media & text block that has the standard image. Confirm that the alternative text option shows in the block settings panel.
Select the media & text block that has the featured image. Confirm that the alternative text option does not show.
Confirm that the block with the featured image has an empty alt attribute in the editor and the front.
Return to the editor, open the media library and add an alt text to the featured image.
Confirm that the block with the featured image uses the correct text in the alt attribute in the editor and the front.