Only show block icon in toolbar for contentOnly blocks when block is a synced block #60647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noisysocks
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +5 B (0%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
andrewserong
approved these changes
Apr 11, 2024
retrofox
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
As part of #60010 I changed
BlockToolbarto show the block icon / block name on blocks that have acontentOnlyediting mode, so that you can see the name of the template part when you've selected it.This PR dials back that behaviour a little to only do this when the block is a synced block (reusable block or a pattern).
Why?
The original change caused some unexpected behaviour for third parties that are using
contentOnly.woocommerce/woocommerce#45908
Arguably this isn't really what
contentOnlyis for, but I don't mind simply dialing back the changes made in #60010 since we only need the block icon to show on patterns.How?
Instead of always rendering
BlockSwitcher, we render it ifisDefaultEditingMode || isSynced. It's a partial reversion of the changes topackages/block-editor/src/components/block-toolbar/index.jsin #60010.Testing Instructions