Template parts: set backpath to patterns page #60667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
oandregal
added
[Type] Enhancement
|
Size Change: -35 B (0%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
oandregal
changed the title
oandregal
requested review from
mcsf,
youknowriad,
jameskoster,
SaxonF,
jorgefilipecosta and
ntsekouras
This was referenced Apr 11, 2024
✅
This one feels a little unexpected. So long as the "Manage all template parts" page is accessible, I think you should be returned there if you actively navigate through it. Obviously this will no longer be an issue once that view is removed.
✅ Nice work! |
mcsf
approved these changes
Apr 11, 2024
packages/edit-site/src/components/sidebar-navigation-screen-template/index.js
Outdated
Show resolved
Hide resolved
|
I really appreciate the work you into this PR's presentation: the break down into distinct commits, each with an explanation and a link, the area-by-area testing instructions, etc! 🎉 |
Reverted it at 5c1609e I'll follow-up tomorrow with a PR to remove the link and will include this commit there. With that in place, the last bit would be to reorganize the sidebar in the Patterns page I believe. The code for Parts was a bit over the place, to be honest 😅 |
|
#60689 removes the "Manage all parts" link, page, and code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #55083
Related #59659 and #60359
What?
Sets the backpath to the Patterns page for all actions related to Template Parts:
Why?
We are trying to get rid of the "Manage all template parts" screen at #60359. This is a preliminary step.
How?
Testing Instructions
Details view sidebar: go back action — from the "Patterns" page.
Details view sidebar: go back action — from the "Manage all parts" page.
Details view sidebar: delete the custom part action.
Editor sidebar: delete the custom part action.
Command bar: delete the custom part action.