Image cropper: remove clientWidth prop with useResizeObserver #60674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellatrix
requested review from
artemiomorales,
michalczaplinski and
ajitbohra
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
ellatrix
commented
Apr 11, 2024
| imageWidthWithinContainer = exceedMaxWidth ? clientWidth : naturalWidth; | ||
| } | ||
|
|
||
| if ( ! isResizable || ! imageWidthWithinContainer ) { |
There was a problem hiding this comment.
I'm not sure I understood why this condition was done this way. imageWidthWithinContainer returns either clientWidth or naturalWidth. Which will always be a number unless something went wrong with the image loading. So a check for ! naturalWidth || ! naturalHeight should be enough here, to make sure the image loaded.
There was a problem hiding this comment.
This goes all the way back to #18811, cc @scruffian
There was a problem hiding this comment.
I'm sorry I don't remember!
There was a problem hiding this comment.
It's fine, I think we're good here
ellatrix
added
[Block] Image
|
Size Change: -192 B (0%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
youknowriad
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Removes
useClientWidthin favour of usinguseResizeObserver.Why?
This has the advantage of (1) being easier to use by consumers and (2) not calculating the clientWidth on block mount, which is expensive and causes a layout calculation.
How?
We can use
useResizeObserverinside the cropper component.Testing Instructions
npm installafter the change in #60581, otherwise this fix won't work as expected.Create an image block. Click on the cropper button. The cropper area should be correct (images should be same width as before you pressed the cropper button).
Now switch between align none and align full. The cropper area should adjust correctly.
You can also test if the cropper works for the Site Logo block.
Testing Instructions for Keyboard
Screenshots or screencast