-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump minimum required PHP version to 7.2. #60714
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
fc75420
to
d1d3fbe
Compare
This question needs to be discussed first: #60680 (comment) |
d45d52f
to
c4c5113
Compare
The PR has received two approvals. |
Thank you for approving the PR, @johnbillion and @Soean! |
Bump minimum required PHP version to 7.2. Co-authored-by: anton-vlasenko <antonvlasenko@git.wordpress.org> Co-authored-by: johnbillion <johnbillion@git.wordpress.org> Co-authored-by: Soean <soean@git.wordpress.org> Co-authored-by: talldan <talldanwp@git.wordpress.org> Co-authored-by: ironprogrammer <ironprogrammer@git.wordpress.org>
Note: this is being included in the Gutenberg 18.2 release, because there was a conflict during release and it just seemed easier path forward. |
What?
testVersion
from7.0-
to7.2-
.Test with previous WP version
fromphp: 7.0
tophp: 7.2
.Fixes #60680.
Why?
WordPress Core parity.
WordPress 6.6.0's minimum supported PHP version is/will be 7.2.
How?
Modifies the plugin header's
Requires PHP:
from7.0
to7.2
.Testing Instructions
gutenberg.php
file, and in the file's DocBlock changeRequires PHP:
back to7.2
.Expected: Stays activated, bulk actions disabled, and a notice appears:
Expected: Bulk edit is disabled;
Cannot Activate
is displayed but not clickable; notice appears: