Editor: Unify PluginSidebarMoreMenuItem #60853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Feature] Extensibility
youknowriad
requested review from
gziolo,
adamsilverstein,
ntwb,
nerrad,
ajitbohra,
ryanwelcher,
juanmaguitar,
fabiankaegy and
ndiego
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -73 B (0%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in f85db18. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/8736021995
|
ellatrix
reviewed
Apr 18, 2024
| _Returns_ | ||
|
|
||
| - `Component`: The component to be rendered. | ||
| Undocumented declaration. |
There was a problem hiding this comment.
I'm planning to do a cleanup PR later to deprecate all of these hooks in the same way.
ellatrix
approved these changes
Apr 18, 2024
49 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #52632
Similar to #59985
What?
This PR unifies the
PluginSidebarMoreMenuItembetween the post and site editors allowing plugin authors to use the same code to load their plugins regardless of the context of the editor.How?
@wordpress/edit-postand@wordpress/edit-siteto.@wordpress/editorTesting Instructions
You should be able to paste something like the following in both post and site editors and have the button show up in the more menu, clicking it opens a sidebar.