Tooltip: remove unecessary delay in tests except where needed #60897
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
mirka
added
[Type] Automated Testing
| - `Text`: Add `text-wrap: pretty;` to improve wrapping. ([#60164](https://github.com/WordPress/gutenberg/pull/60164)). | ||
| - `Navigator`: Navigation to the active path doesn't create a new location history. ([#60561](https://github.com/WordPress/gutenberg/pull/60561)) | ||
| - `FormToggle`: Forwards ref to input. ([#60234](https://github.com/WordPress/gutenberg/pull/60234)). | ||
| - `ToggleControl`: Forwards ref to FormToggle. ([#60234](https://github.com/WordPress/gutenberg/pull/60234)). |
| // Prevent this test from interfering with the next one. | ||
| // "Tooltips appear instantly if another tooltip has just been hidden." | ||
| // See: https://github.com/WordPress/gutenberg/pull/57345#discussion_r1435495655 | ||
| await sleep( 3000 ); |
There was a problem hiding this comment.
Ideally, there would be a better way, and something more specific to wait for, but this is not related to the PR, so 🤷
There was a problem hiding this comment.
I believe this won't be needed with @ariakit/react@^0.4.2.
There was a problem hiding this comment.
Oh I didn't realize we're still on 0.3.12, is there any discussion on upgrading? Any relevant blockers? @tyxla
There was a problem hiding this comment.
I think there were some v0.4.0 breaking changes we need to address, like:
- We may have to manually set
role="gridcell"to grid cells withinCompositewhen usingrole="grid" - Data attributes can no longer be empty strings
- Type changes
Nothing too critical though - I'd go through all the breaking changes and if there are any that apply to the package, verify that we update properly without breaking something.
Also I haven't been directly involved with updating Ariakit before, so perhaps @mirka might know more.
There was a problem hiding this comment.
For the protocol, I'd love for us to update to the latest version. There are so many improvements and new features we could benefit from!
What?
There was a need to add a delay after every Tooltip test. After an Ariakit update, it's not necessary anymore for every test. See discussion: #57345 (comment)
Why?
Faster tests.
How?
Removed delay after every test and only added where necessary (after one specific test).
Testing Instructions
Run Tooltip unit tests.
Testing Instructions for Keyboard
N/A
Screenshots or screencast
N/A