Avoid unnecessary heading level and paragraph transform via keyboard shortcuts #60955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afercia
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +21 B (0%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
|
Thank you @Mamaduka 👋🏽 |
afercia
deleted the
fix/optimize-heading-level-paragraph-transform-via-keyboard-shortcuts
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #60949
What?
When using keybaord shortcuts to change Heading level or transforming to - from Paragraph, the block transform runs even when the Heading already has the destination level or the Paragraph is already... a Paragraph.
Why?
Running code to transform a block to the same block type / level is unnecessary and should be avoided.
How?
Check the type of transform triggered via keyboard shorcuts and returns early when the transform is not necessary.
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast