Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Components: Assess stabilization of Surface #61065

Draft
wants to merge 2 commits into
base: trunk
Choose a base branch
from
Draft

Components: Assess stabilization of Surface #61065

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
157bfaa
Remove "experimental" designation for `Surface`
fullofcaffeine Apr 19, 2024
f48760d
Add CHANGELOG entry
fullofcaffeine Apr 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/components/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

## Unreleased

- `Surface`: Remove "experimental" designation ([#61065](https://github.com/WordPress/gutenberg/pull/61065)).

### Enhancements

- `InputControl`: Add a password visibility toggle story ([#60898](https://github.com/WordPress/gutenberg/pull/60898)).
Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/elevation/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ The shadow effect is generated using the `value` prop.
```jsx
import {
__experimentalElevation as Elevation,
__experimentalSurface as Surface,
Surface,
__experimentalText as Text,
} from '@wordpress/components';

Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/elevation/component.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ function UnconnectedElevation(
* ```jsx
* import {
* __experimentalElevation as Elevation,
* __experimentalSurface as Surface,
* Surface,
* __experimentalText as Text,
* } from '@wordpress/components';
*
Expand Down
8 changes: 7 additions & 1 deletion packages/components/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,13 @@ export { default as SnackbarList } from './snackbar/list';
export { Spacer as __experimentalSpacer } from './spacer';
export { Scrollable as __experimentalScrollable } from './scrollable';
export { default as Spinner } from './spinner';
export { Surface as __experimentalSurface } from './surface';
export {
/**
* @deprecated Import `Surface` instead.
*/
Surface as __experimentalSurface,
Surface,
} from './surface';
export { default as TabPanel } from './tab-panel';
export { Text as __experimentalText } from './text';
export { default as TextControl } from './text-control';
Expand Down
6 changes: 1 addition & 5 deletions packages/components/src/surface/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,5 @@
# Surface

<div class="callout callout-alert">
This feature is still experimental. “Experimental” means this is an early implementation subject to drastic and breaking changes.
</div>

`Surface` is a core component that renders a primary background color.

## Usage
Expand All @@ -12,7 +8,7 @@ In the example below, notice how the `Surface` renders in white (or dark gray if

```jsx
import {
__experimentalSurface as Surface,
Surface,
__experimentalText as Text,
} from '@wordpress/components';

Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/surface/component.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ function UnconnectedSurface(
*
* ```jsx
* import {
* __experimentalSurface as Surface,
* Surface,
* __experimentalText as Text,
* } from '@wordpress/components';
*
Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/surface/stories/index.story.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import { Text } from '../../text';

const meta: Meta< typeof Surface > = {
component: Surface,
title: 'Components (Experimental)/Surface',
title: 'Components/Surface',
argTypes: {
children: { control: { type: null } },
as: { control: { type: 'text' } },
Expand Down
2 changes: 1 addition & 1 deletion storybook/manager-head.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<script>
( function redirectIfStoryMoved() {
const PREVIOUSLY_EXPERIMENTAL_COMPONENTS = [ 'navigation' ];
const PREVIOUSLY_EXPERIMENTAL_COMPONENTS = [ 'navigation', 'surface' ];
const REDIRECTS = [
{
from: /\/components-deprecated-/,
Expand Down
Loading