Update alignment of preview contents in Patterns and Templates data views #61190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameskoster
added
[Type] Enhancement
|
This looks like a substantial step forward, nice work. Question: what happens when a pattern is much taller than the available space, does it stick to the top and the bottom is elided? Or is it elided in both top and bottom? |
|
Size Change: -1 B (0%) Total Size: 1.74 MB
ℹ️ View Unchanged
|
The former. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Flaky tests detected in bf6f030. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/8877259735
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's tricky to find a solution that works perfectly given the diverse arrangements that can exist in block patterns / templates. But the current implementation feels backwards. Templates which tend to be longer are centrally aligned which can result in previews where the header isn't flush with the top of the container. The top alignment applied to patterns suggest an inaccurate height.
This PR flips the treatments:
Patterns
Before (top aligned)
After (centrally aligned)
Templates
Before (centrally aligned)
After (top aligned)
While this is a small improvement, ideally consumers are offered more expressive display options (#60891) in the future.