withBlockTree: simplify code that replaces/removes controlled blocks #61234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsnajdr
added
[Type] Code Quality
jsnajdr
force-pushed
the
update/with-block-tree-controlled
branch
from
1b09f29
to
d666359
Compare
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
ellatrix
reviewed
Apr 30, 2024
| if ( ! inserterClientIds[ clientId ] ) { | ||
| newState.tree.delete( 'controlled||' + clientId ); | ||
| } | ||
| } ); |
There was a problem hiding this comment.
Is a for loop not better even?
There was a problem hiding this comment.
Maybe it is. This reducer.js file uses both variants 10+ times -- there is an opportunity for a PR that unifies them one way or the other.
|
Size Change: -1 B (0%) Total Size: 1.74 MB
ℹ️ View Unchanged
|
ellatrix
approved these changes
Apr 30, 2024
|
Flaky tests detected in d666359. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/8893572507
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A little thing I noticed recently when reviewing the
useBlockSyncchanges. The code that replaces/removes controlled blocks doesn't need to use a complex.concat/.filter/.mapmachinery. It can be a simple loop over the list ofclientIds.