DataViews: Type the ViewList component #61246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Type] Code Quality
youknowriad
requested review from
oandregal,
sirreal,
ellatrix,
jorgefilipecosta and
ntsekouras
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
youknowriad
commented
Apr 30, 2024
|
Size Change: +12 B (0%) Total Size: 1.74 MB
ℹ️ View Unchanged
|
youknowriad
force-pushed
the
update/dataviews-view-list-types
branch
from
2d97093 to
68f3265
Compare
|
Flaky tests detected in 68f3265. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/8908354138
|
sirreal
approved these changes
May 2, 2024
youknowriad
force-pushed
the
update/dataviews-view-list-types
branch
from
0168d6f to
e9f311e
Compare
oandregal
reviewed
May 8, 2024
| [ onSelectionChange ] | ||
| ); | ||
|
|
||
| const getItemDomId = useCallback( | ||
| ( item ) => ( item ? `${ baseId }-${ getItemId( item ) }` : undefined ), | ||
| ( item?: Item ) => ( item ? `${ baseId }-${ getItemId( item ) }` : '' ), |
There was a problem hiding this comment.
Returning an empty string instead of undefined changes the behavior of getItemDomId breaking the keyboard navigation. Fix at #61478
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #55083
Follow-up to #61185
What?
The DataViews package is a types heavy package. There's a lot of structures that need to be documented properly. So this continues the effort to add explicit types to the package. This PR focuses on typing the ViewList component which forces us to enhance the "View" type.
Testing instructions
There's no functional change, it's essentially a code quality + documentation change.