Eliminate obsolete call to onChange when RichText componentWillUnmount #6150
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6134.
When
wp.hooks.addFilter( 'blocks.BlockEdit'… )
is used to extend blocks which contain theRichEdit
component, this will cause the component to be unmounted and with thatonChange
will be called:gutenberg/blocks/rich-text/index.js
Lines 702 to 704 in 004cb8b
This results in the editor being put into a dirty state upon initialization, even if no changes have been made by the user. This bit of code actually appears to be a remnant of the past, @iseulde in #6134 (comment):
But @youknowriad adds:
I'm not sure how best to go about testing this change, but I wanted to open a PR at least to get the fix off the ground.