Scripts: Add RTLCSS to wp-scripts. #61540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryelle
requested review from
gziolo,
ntwb,
nerrad,
ajitbohra and
ryanwelcher
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
There are now two additional CSS files, `style-index-rtl.css` and `index-rtl.css`.
|
Size Change: +2.26 kB (+0.13%) Total Size: 1.74 MB
ℹ️ View Unchanged
|
gziolo
approved these changes
May 10, 2024
gziolo
reviewed
May 10, 2024
|
Wooohooo finally! 🎉 |
|
🎉 Thanks for merging @gziolo! |
|
Thanks for this! Is there any option to opt-out of it, especially in instances where developers are extending |
|
Array.prototype.filter is your friend, you can use it to exclude certain plugins from the default list. Or just provide your own list. |
|
Here's how I was able to exclude RTL in my webpack config: const defaultConfig = require( '@wordpress/scripts/config/webpack.config' );
const RtlCssPlugin = require( 'rtlcss-webpack-plugin' );
module.exports = {
...defaultConfig,
...{
plugins: [
...defaultConfig.plugins.filter(
(filter) => ! (filter instanceof RtlCssPlugin)
),
// Other plugins.
]
}
}; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #29605 — This simply adds an RTLCSS step to the webpack build process in wp-scripts.
Why?
Core supports switching out the CSS files automatically if a
[name]-rtl.cssexists, but wp-scripts doesn't generate that currently. This adds the rtlcss plugin, which automatically generates the RTL-ified file for any CSS files. These are then automatically loaded on RTL sites when registered inblock.json(sinceregister_block_style_handlehandles this).How?
Adds the RTLCSS plugin.
Testing Instructions
/path-to/gutenberg/packages/scripts/bin/wp-scripts.js build-rtl.cssfilesNote: I also tested this with a project that already includes the custom webpack code mentioned in this comment, and there were no issues with there being two RTLCSS plugins.