GridItemResizer: Fix resizing when List View is open #61643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noisysocks
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
There was a problem hiding this comment.
Nice one, that appears to have done the trick! I just gave it a very quick test and it's testing nicely for me in the post and site editors. I've run out of time to give this a proper code review today, but just wanted to confirm that it looks like it's resolved the bug 👍
tellthemachines
approved these changes
May 14, 2024
|
Size Change: -122 B (-0.01%) Total Size: 1.74 MB
ℹ️ View Unchanged
|
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes a bug noticed in #61641 (which is in turn part of #61633) where the grid item resizes behaves funnily when the List View is opened.
How?
Opening the List View changes the origin that
getBoundingClientRect()uses which means that the bounds rectangle we pass toResizableBoxis no longer correct.We could update our logic that calculate
boundsto accomodate the List View, but I think this is too complicated.So instead I replaced the logic we use for calculating bounds with something that I think is simpler which is setting
ResizableBox'sboundsprop to be.block-editor-grid-visualizer__gridwhich we know will be on screen, not in the iframe, and the correct size and position to act as bounds.I'm doing some ref passing instead of
querySelectorbecause I think it makes the relationship more explicit.Testing Instructions