Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PaletteEdit: Fix flaky test #61791

Merged
merged 1 commit into from
May 20, 2024
Merged

PaletteEdit: Fix flaky test #61791

merged 1 commit into from
May 20, 2024

Conversation

tyxla
Copy link
Member

@tyxla tyxla commented May 20, 2024

What?

Fixes a flaky PaletteEdit test

Why?

Because it's flaky. Example:

How?

We're now explicitly waiting for the "Remove all colors" button to appear.

Testing Instructions

All tests should pass. Make sure to do multiple runs of this one to ensure it's no longer flaky:

npm run test:unit:watch packages/components/src/palette-edit/test/index.tsx

Testing Instructions for Keyboard

None

Screenshots or screencast

None

@tyxla tyxla added [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. [Package] Components /packages/components labels May 20, 2024
@tyxla tyxla requested review from Mamaduka, jsnajdr and a team May 20, 2024 12:58
@tyxla tyxla self-assigned this May 20, 2024
@tyxla tyxla requested a review from ajitbohra as a code owner May 20, 2024 12:58
Copy link

github-actions bot commented May 20, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: tyxla <tyxla@git.wordpress.org>
Co-authored-by: cbravobernal <cbravobernal@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link
Contributor

@cbravobernal cbravobernal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested 10 runs.
Without: 1/5 failed.
With: 0/5 failed.

@tyxla tyxla enabled auto-merge (squash) May 20, 2024 13:04
Copy link

Flaky tests detected in 6ce2cdf.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/9159075288
📝 Reported issues:

@tyxla tyxla merged commit 6b5d388 into trunk May 20, 2024
69 checks passed
@tyxla tyxla deleted the fix/palette-edit-flaky-test branch May 20, 2024 14:01
@github-actions github-actions bot added this to the Gutenberg 18.5 milestone May 20, 2024
@Mamaduka
Copy link
Member

Unfortunately, this doesn't seem to have resolved the issue - https://github.com/WordPress/gutenberg/actions/runs/9171026029/job/25214476473?pr=61813#step:6:200.

@tyxla
Copy link
Member Author

tyxla commented May 21, 2024

Unfortunately, this doesn't seem to have resolved the issue - https://github.com/WordPress/gutenberg/actions/runs/9171026029/job/25214476473?pr=61813#step:6:200.

This one seems to be a different one. Fix suggested in #61818.

patil-vipul pushed a commit to patil-vipul/gutenberg that referenced this pull request Jun 17, 2024
Co-authored-by: tyxla <tyxla@git.wordpress.org>
Co-authored-by: cbravobernal <cbravobernal@git.wordpress.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Components /packages/components [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants