Block Editor: Unlock private setting keys at the file level #61813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Code Quality
Mamaduka
requested review from
aaronrobertshaw and
ellatrix
and removed request for
aaronrobertshaw
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
ellatrix
approved these changes
May 21, 2024
|
There's a few left: gutenberg/packages/block-editor/src/components/colors-gradients/control.js Lines 109 to 112 in 0f68078 gutenberg/packages/block-editor/src/components/global-styles/color-panel.js Lines 210 to 213 in 0f68078 |
|
Size Change: -17 B (0%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
|
Yes, the circular dependency issue was resolved in #61102. |
|
Flaky tests detected in ade98bd. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/9171026024
|
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Jun 4, 2024
…s#61813) * Block Editor: Unlock private setting keys at the file level * Feedback Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: ellatrix <ellatrix@git.wordpress.org>
patil-vipul
pushed a commit
to patil-vipul/gutenberg
that referenced
this pull request
Jun 17, 2024
…s#61813) * Block Editor: Unlock private setting keys at the file level * Feedback Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: ellatrix <ellatrix@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
A micro-optimization unlocks private setting keys (
Symbol) at the file level. These values don't change with the component life-cycle.Testing Instructions
CI checks are green.