Components: Fix React Warning triggers by the new JSX transform #61917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Feature] UI Components
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
youknowriad
added
Global Styles
|
Size Change: -204 B (-0.01%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 228918f. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/9220516861
|
ellatrix
reviewed
May 24, 2024
| @@ -251,7 +251,8 @@ function ColorPanelDropdown( { | |||
| <div className="block-editor-panel-color-gradient-settings__dropdown-content"> | |||
| { tabs.length === 1 && ( | |||
| <ColorPanelTab | |||
| { ...tabs[ 0 ] } | |||
| keu={ firstTabKey } | |||
There was a problem hiding this comment.
I'm not seeing a warning when opening the Colors tab in global styles 🤔
There was a problem hiding this comment.
Are you sure you have SCRIPT_DEBUG true
There was a problem hiding this comment.
Also it happens only when there's just one tab in the color dropdown.
There was a problem hiding this comment.
Yes, it's true. I guess I'm not sure what you mean with dropdown, but I have one palette and multiple "elements"
Mamaduka
approved these changes
May 24, 2024
Locally, that could be a good idea, in CI I think e2e tests should probably run in prod. |
|
I meant test PR just to see warnings and fix them. |
This was referenced May 24, 2024
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Jun 4, 2024
…Press#61917) Co-authored-by: youknowriad <youknowriad@git.wordpress.org> Co-authored-by: ellatrix <ellatrix@git.wordpress.org> Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
patil-vipul
pushed a commit
to patil-vipul/gutenberg
that referenced
this pull request
Jun 17, 2024
…Press#61917) Co-authored-by: youknowriad <youknowriad@git.wordpress.org> Co-authored-by: ellatrix <ellatrix@git.wordpress.org> Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a tiny PR to get rid of a React warning that is triggered when you open one of the color element dropdowns in the global styles sidebar. If you have SCRIPT_DEBUG enabled, you can see a warning in trunk when opening components panels in global styles, this PR solves that.