Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Media & text: Update the image replacement logic #62030

Merged
merged 21 commits into from
Jun 19, 2024
Merged

Media & text: Update the image replacement logic #62030

merged 21 commits into from
Jun 19, 2024

Commits on May 27, 2024

  1. Media & text: Update the image replacement logic when the media is on… 

    … the right
    @carolinan
    carolinan committed May 27, 2024
    Configuration menu
    Copy the full SHA
    f84d248 View commit details
    Browse the repository at this point in the history

Commits on May 28, 2024

  1. Try to fix PHP coding standard issues.

    @carolinan
    carolinan committed May 28, 2024
    Configuration menu
    Copy the full SHA
    0f4a432 View commit details
    Browse the repository at this point in the history

  2. Look for the figure with the correct class name instead of any figure… 

    … tag.
    @carolinan
    carolinan committed May 28, 2024
    Configuration menu
    Copy the full SHA
    0865ac3 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'trunk' into try/media-text--media-on-right

    @carolinan
    carolinan committed May 28, 2024
    Configuration menu
    Copy the full SHA
    0e67eaa View commit details
    Browse the repository at this point in the history

  4. Update the logic for inserting the featured image 

    Use ´while´ to locate the correct ´figure´ tag depending on the block settings.
Add support for the image fill setting.
    @carolinan
    carolinan committed May 28, 2024
    Configuration menu
    Copy the full SHA
    884f732 View commit details
    Browse the repository at this point in the history

  5. Try to fix PHP CS issues with spacing and the arrays.

    @carolinan
    carolinan committed May 28, 2024
    Configuration menu
    Copy the full SHA
    c326e19 View commit details
    Browse the repository at this point in the history

  6. Try to fix PHP CS issues with spacing inside the arrays.

    @carolinan
    carolinan committed May 28, 2024
    Configuration menu
    Copy the full SHA
    45b2fb3 View commit details
    Browse the repository at this point in the history

Commits on May 30, 2024

  1. Add a test class for the Media & Text block

    @carolinan
    carolinan committed May 30, 2024
    Configuration menu
    Copy the full SHA
    ee92f20 View commit details
    Browse the repository at this point in the history

Commits on May 31, 2024

  1. Merge branch 'trunk' into try/media-text--media-on-right

    @carolinan
    carolinan committed May 31, 2024
    Configuration menu
    Copy the full SHA
    e60ac3d View commit details
    Browse the repository at this point in the history

  2. Replace the $image_tag variable and remove the CSS class on the img tag 

    Neither the variable or the CSS class are needed, and they can be removed in favor of an empty
`<img>` tag.
    @carolinan
    carolinan committed May 31, 2024
    Configuration menu
    Copy the full SHA
    c62c46c View commit details
    Browse the repository at this point in the history

  3. Revert "Replace the $image_tag variable and remove the CSS class on t… 

    …he img tag"

This reverts commit c62c46c.
    @carolinan
    carolinan committed May 31, 2024
    Configuration menu
    Copy the full SHA
    912ae47 View commit details
    Browse the repository at this point in the history

  4. Add an if statement around the figure tag and the image tag 

    Add an if statement around the figure tag and the image tag, to make sure that the id is removed and the attributes are updated on the correct tags.
    @carolinan
    carolinan committed May 31, 2024
    Configuration menu
    Copy the full SHA
    287b230 View commit details
    Browse the repository at this point in the history

  5. Try to fix PHP CS issues 

    Move the closing parenthesis on the array that includes the figure tag name and id.
Remove whitespace.
    @carolinan
    carolinan committed May 31, 2024
    Configuration menu
    Copy the full SHA
    ff42bab View commit details
    Browse the repository at this point in the history

  6. Split test_render_block_core_media_text_featured_image into four tests

    @carolinan
    carolinan committed May 31, 2024
    Configuration menu
    Copy the full SHA
    117267c View commit details
    Browse the repository at this point in the history

Commits on Jun 4, 2024

  1. Update phpunit/blocks/render-block-media-text-test.php 

    Co-authored-by: Ramon <ramonjd@users.noreply.github.com>
    @carolinan @ramonjd
    carolinan and ramonjd authored Jun 4, 2024
    Configuration menu
    Copy the full SHA
    5efa53b View commit details
    Browse the repository at this point in the history

  2. Merge branch 'trunk' into try/media-text--media-on-right

    @carolinan
    carolinan committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    e0402d5 View commit details
    Browse the repository at this point in the history

  3. Move the PHP variables for media size slug and image tag

    @carolinan
    carolinan committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    2bb1e79 View commit details
    Browse the repository at this point in the history

Commits on Jun 5, 2024

  1. Try to fix PHPCS spacing issues

    @carolinan
    carolinan authored Jun 5, 2024
    Configuration menu
    Copy the full SHA
    2d44777 View commit details
    Browse the repository at this point in the history

Commits on Jun 10, 2024

  1. Merge branch 'trunk' into try/media-text--media-on-right

    @carolinan
    carolinan committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    a0b030d View commit details
    Browse the repository at this point in the history

Commits on Jun 18, 2024

  1. Add a helper method for wp_query (post data) to reduce code duplication

    @carolinan
    carolinan committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    dbe8aeb View commit details
    Browse the repository at this point in the history

  2. PHP coding standards: adjust spacing around equal signs.

    @carolinan
    carolinan committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    0b03266 View commit details
    Browse the repository at this point in the history