Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link Control: Fix focus handlers in development mode #62141

Merged
merged 1 commit into from
May 30, 2024
Merged

Link Control: Fix focus handlers in development mode #62141

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion packages/block-editor/src/components/link-control/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,7 +220,6 @@ function LinkControl( {
// because otherwise using the keyboard to select text
// *within* the link format is not possible.
if ( isMounting.current ) {
isMounting.current = false;
return;
}

Expand All @@ -238,6 +237,16 @@ function LinkControl( {
isEndingEditWithFocus.current = false;
}, [ isEditingLink, isCreatingPage ] );

// The component mounting reference is maintained separately
// to correctly reset values in `StrictMode`.
useEffect( () => {
isMounting.current = false;

return () => {
isMounting.current = true;
};
}, [] );

const hasLinkValue = value?.url?.trim()?.length > 0;

/**
Expand Down
Loading