-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DataViews: Improve UX around filter customization of bundled data views #62157
DataViews: Improve UX around filter customization of bundled data views #62157
Conversation
- Hide the filter option which is pre-applied by the view. - Hide the "Reset" button when no other filter is applied other than the pre-applied filter by view. - When "Reset" button is clicked reset the filter to the view pre-applied filter state. Signed-off-by: Souptik Datta <souptikdatta2001@gmail.com>
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @Souptik2001! In case you missed it, we'd love to have you join us in our Slack community. If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information. |
Thank you for the continued energy on these issues @Souptik2001 ❤️ This is working well for me on the Pages views, however I'm seeing errors on Templates and Patterns pages. |
Signed-off-by: Souptik Datta <souptikdatta2001@gmail.com>
Ahhh it's a miss from my side. Sorry, I missed to test it. 🙇 Fixed it now. Now the templates should also behave the same way as we have implemented for pages! Thanks @jameskoster! Please let me know if there are any other issues. 🙌 |
Thanks for the update 👍 We've most likely missed the boat for 6.6 now, so this will end up being a 6.7 consideration. That may mean delaying the merge a little, but that gives us time to get more feedback from @WordPress/gutenberg-design. |
Gotcha! Thanks @jameskoster! 🙇 Will be keeping an eye here and will make any change as required.. 🙌 |
Since this will now be a 6.7 item, I think it's good to merge and begin gathering more feedback, pending a code review, |
@DaniGuardiola I pinged you on a related issue, would you be up for helping here as well? Thank you. |
Hi @Souptik2001 thanks for preparing the PR and the patience in waiting for feedback. I've taken a look at this and prepared an alternative at #65264 Thought it'd be less intrusive that pushing to this PR. You still should be credited as a co-author there. |
Sure! thanks a lot @oandregal ! |
Closing in favour of #65295 which was merged. |
What?
Improve UX around filter customization of bundled data views
Why?
Addressed first three points of - #60468
The UX of applying filters on a bundled view can be a little confusing.
For example we are on the "Scheduled" view -
But doing those we will still be on the "Scheduled" bundled view page. So, seeing that screen there is no relation between the filters applied and the view.
Also when we click on the "Reset" button when on any bundled view, it resets all the filter without respecting the view.
How?
Testing Instructions
Check the screencast below or the points written -
Testing Instructions for Keyboard
Screenshots or screencast
Screen.Recording.2024-05-31.at.12.55.05.AM.mov