Fix syncing of publish date between publish and post status panel #62165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
youknowriad
reviewed
May 31, 2024
| startOfWeek: getSettings().l10n.startOfWeek, | ||
| onChange, | ||
| currentDate: isCompact ? undefined : currentDate, | ||
| currentTime: isCompact ? currentDate : undefined, |
There was a problem hiding this comment.
It's not clear to me why isCompact impacts currentData prop?
Do we want the date to be "controlled" outside the entity in the case of the post status. What's happening exactly here?
There was a problem hiding this comment.
TimePicker component has different name for the currentDate and is currentTime.
There was a problem hiding this comment.
Naming around the TimePicker component is confusing.
There was a problem hiding this comment.
ah ok then this fix makes sense :P
Both of these components should just use value onChange to be honest.
|
Size Change: +25 B (0%) Total Size: 1.74 MB
ℹ️ View Unchanged
|
oandregal
approved these changes
May 31, 2024
|
I see this is blocked by the performance job, which is failing in other PRs as well (different test suite: post-editor, site-editor, front-end-classic-theme). Tested locally with the lastest wp-env (to detect if it was a change in core) but I cannot reproduce. |
ntsekouras
force-pushed
the
fix/sync-publish-date-properly
branch
from
b3ff7af
to
4ce0884
Compare
|
Flaky tests detected in 4ce0884. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/9316524086
|
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Jun 4, 2024
…rdPress#62165) Co-authored-by: ntsekouras <ntsekouras@git.wordpress.org> Co-authored-by: youknowriad <youknowriad@git.wordpress.org> Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: oandregal <oandregal@git.wordpress.org> Co-authored-by: annezazu <annezazu@git.wordpress.org>
patil-vipul
pushed a commit
to patil-vipul/gutenberg
that referenced
this pull request
Jun 17, 2024
…rdPress#62165) Co-authored-by: ntsekouras <ntsekouras@git.wordpress.org> Co-authored-by: youknowriad <youknowriad@git.wordpress.org> Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: oandregal <oandregal@git.wordpress.org> Co-authored-by: annezazu <annezazu@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes: #62150
In this PR I missed testing properly the syncing in both directions between the publish date and post status panel, when we update the publish date. This is the fix for that.
Testing Instructions
scheduledstatus