Remove unused syncDerivedUpdates action
#62229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SantosGuillamot
added
[Feature] Synced Patterns
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -2 B (0%) Total Size: 1.74 MB
ℹ️ View Unchanged
|
kevin940726
reviewed
Jun 3, 2024
| @@ -1,4 +1,4 @@ | |||
| // Keep track of the blocks that should not be pushing an additional | |||
| // undo stack when editing the entity. | |||
| // See the implementation of `syncDerivedUpdates` and `useBlockSync`. | |||
| // See the implementation of `useBlockSync`. | |||
| export const undoIgnoreBlocks = new WeakSet(); | |||
There was a problem hiding this comment.
I believe this variable isn't needed anymore either?
There was a problem hiding this comment.
I didn't remove it because it was being used in useBlockSync. But maybe we can remove these lines as well? You know better than me 😄
There was a problem hiding this comment.
Yep! They are not used anywhere else and were introduced in the same PR.
There was a problem hiding this comment.
Perfect! I just removed it in this commit. Let's see if tests pass.
|
Flaky tests detected in d76e288. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/9363229556
|
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Jun 4, 2024
* Remove `syncDerivedUpdates` function * Remove `syncDerivedUpdates` mention * Remove unused `undoIgnoreBlocks`
|
@SantosGuillamot This is my friendly reminder to follow this #62229 (comment) :) |
|
I'm really sorry for that. Totally my fault. I'll take it into account for future pull requests. And thanks for the reminder. |
patil-vipul
pushed a commit
to patil-vipul/gutenberg
that referenced
this pull request
Jun 17, 2024
* Remove `syncDerivedUpdates` function * Remove `syncDerivedUpdates` mention * Remove unused `undoIgnoreBlocks`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Remove
syncDerivedUpdatesprivate action.Why?
In this pull request, how pattern overrides are handled was changed and
syncDerivedUpdatesaction doesn't seem to be used anymore. I assume it it better to remove it and add it back if needed.How?
Just removing the code.
Testing Instructions
Tests should pass.