Editor: Use the Editor component in the post editor. #62339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Type] Code Quality
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
youknowriad
commented
Jun 5, 2024
| import { store as coreStore } from '@wordpress/core-data'; | ||
| import { store as editorStore } from '@wordpress/editor'; | ||
|
|
||
| export const getEditedPostTemplateId = createRegistrySelector( |
There was a problem hiding this comment.
This is the same logic that was in getEditedPostTemplate but I moved it to this new selector because we don't really need the full object.
|
Size Change: -90 B (-0.01%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
ramonjd
approved these changes
Jun 6, 2024
There was a problem hiding this comment.
Here's what I tested:
✅ Post editor loads find with all expected functionality
✅ Displaying/swapping/editing post/page templates works as expected
✅ General editing/adding blocks/styling/saving
Also tested:
✅ All the of the above in a Classic theme
✅ All of the above using a custom post type
✅ All of the above using an Author account
✅ All of the above for pages set as home/posts pages
E2e tests should probably cover everything here but smoke testing editing various entities in the site editor would be helpful.
I assume site editor should be post-editor, but I smoke tested site editor and editing pages as well. 👍🏻
youknowriad
force-pushed
the
update/editor-edit-post
branch
from
5707016 to
a069531
Compare
24 tasks
ellatrix
added
Backport to WP 6.7 Beta/RC
patil-vipul
pushed a commit
to patil-vipul/gutenberg
that referenced
this pull request
Jun 17, 2024
Co-authored-by: youknowriad <youknowriad@git.wordpress.org> Co-authored-by: ramonjd <ramonopoly@git.wordpress.org>
ntsekouras
pushed a commit
that referenced
this pull request
Jul 2, 2024
Co-authored-by: youknowriad <youknowriad@git.wordpress.org> Co-authored-by: ramonjd <ramonopoly@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #52632
Similar to #62274 but for the post editor.
What?
This PR updates the post editor to use the
Editorcomponent to render a full editor with UI and context, similar to how we do it in the site editor.Note that there are still some extra props that we should ideally try to mitigate/remove over time. But for now these are necessary to account for the differences and history of post/site editor packages.
Testing Instructions
E2e tests should probably cover everything here but smoke testing editing various entities in the site editor would be helpful.