Core Data: Fix errors when the entities list doesn't contain config key #62346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Bug
|
Size Change: +9 B (0%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
Mamaduka
added
the
[Status] Blocked
This comment was marked as outdated.
This comment was marked as outdated.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Mamaduka
force-pushed
the
try/fix-get-entity-records-errors
branch
from
0011ca6
to
105935f
Compare
Mamaduka
commented
Jun 6, 2024
| @@ -110,7 +110,8 @@ export function items( state = {}, action ) { | |||
| [ context ]: { | |||
| ...state[ context ], | |||
| ...action.items.reduce( ( accumulator, value ) => { | |||
| const itemId = value[ key ]; | |||
| const itemId = value?.[ key ]; | |||
There was a problem hiding this comment.
It turns out that undefined is a "valid" item ID, and site settings are keyed using it.
Screenshot
Mamaduka
removed
the
[Status] Blocked
tyxla
reviewed
Jun 6, 2024
There was a problem hiding this comment.
While the proposed changes look mostly safe, I wasn't able to reproduce the original error, so I can't confirm that this PR resolves it. I've been following the testing instructions from this PR on trunk, but no error appears. Any idea what I might be missing?
| @@ -232,7 +233,7 @@ const receiveQueries = compose( [ | |||
| return { | |||
| itemIds: getMergedItemIds( | |||
| state?.itemIds || [], | |||
| action.items.map( ( item ) => item[ key ] ), | |||
| action.items.flatMap( ( item ) => item?.[ key ] ?? [] ), | |||
There was a problem hiding this comment.
Won't action.items be an array of objects? If that's the case, it feels odd if item?.[ key ] falls back to an empty array.
There was a problem hiding this comment.
This line extracts the nextItemIds array. It's usually an array of key items. When every key is undefined we want to pass an empty array.
This flatMap pattern is from MDN docs. It's the same as items.map( ( item ) => item?.[ key ] ).filter( ( itemId ) => itemId !== undefined );
Should I use explicit iteration?
There was a problem hiding this comment.
Thanks for confirming. I think this is too idiomatic for most tastes though - I know the pattern and still didn't think of it when I first saw it. I think when one sees .flatMap() they expect this works with nested arrays, and this isn't the case here, so it could create false expectations. The fact that this area of the code isn't properly typed doesn't make it better. So yes, if I could choose, I'd prefer being more explicit here.
Correct, when I add logging there, I see the error logged, but I still don't understand in what circumstances it will actually be manifested as an error - it's supposed to be caught there, no? |
|
The error can occur when a response for The example site entity used here returns a single object with properties for the |
|
Flaky tests detected in cfe1d0f. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/9399454129
|
Mamaduka
force-pushed
the
try/fix-get-entity-records-errors
branch
from
cfe1d0f
to
10a0ac2
Compare
|
Worth backporting? |
Mamaduka
added
the
Backport to WP 6.7 Beta/RC
|
This is probably not a new bug, but it's worth backporting alongside the #62322. |
ellatrix
pushed a commit
that referenced
this pull request
Jun 11, 2024
…ey (#62346) Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: tyxla <tyxla@git.wordpress.org> Co-authored-by: Mr2P <mr2p@git.wordpress.org>
ellatrix
pushed a commit
that referenced
this pull request
Jun 11, 2024
…ey (#62346) Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: tyxla <tyxla@git.wordpress.org> Co-authored-by: Mr2P <mr2p@git.wordpress.org>
patil-vipul
pushed a commit
to patil-vipul/gutenberg
that referenced
this pull request
Jun 17, 2024
…ey (WordPress#62346) Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: tyxla <tyxla@git.wordpress.org> Co-authored-by: Mr2P <mr2p@git.wordpress.org>
ellatrix
removed
the
Backport to WP 6.7 Beta/RC
|
This was cherry-picked to the wp/6.6 branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Closes #62311.
PR fixes errors when data returned by the endpoint for
getEntityRecordsdoesn't contain config or defaultkeyproperty.Testing Instructions
wp.data.select( 'core' ).getEntityRecords( 'root', 'site' );.wp.data.select( 'core' ).getResolutionError( 'getEntityRecords', [ 'root', 'site' ] );.Testing Instructions for Keyboard
Same.