Global styles: display tooltips for pagination buttons on styles revision #62395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramonjd
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +45 B (0%) Total Size: 1.74 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in dd149f2. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/9412905191
|
|
Will try to use the existing icons |
|
In the last two commits I replaced the unicode characters with SVG icons and cleaned up a bit the CSS. Buttons have the same 32 by 32 pixels size. The alignment of the icons within the buttons has slightly improved, as they now use more standard CSS / props. Screenshot before and after:
|
t-hamano
reviewed
Jun 8, 2024
There was a problem hiding this comment.
I think this is ideal from an accessibility and code standpoint, but since it's a design change it might be a good idea to get some design feedback.
| Before | After |
|---|---|
 |
 |
If these icons feel a bit large, do we need previousSmall and nextSmall icons as well as chevronLeftSmall and chevronRightSmall? cc @WordPress/gutenberg-design
I think this PR is okay to ship as is, but in the future, we need to apply the same approach and design to other paginations.
Patterns Dialog
Font Library: Install Fonts
Ah, I was wrong, if the icon size is not suitable, we can simply adjust it with the |
|
At the moment, data views use the regular size chevron, as a 24x24px icon inside a 32x32 button:
Ideally button sizes here are the same. If we run out of space for this particular interface, we can consider removing the first-page/last-page interface, or do something else. |
A while ago I created an issue to unify the various Pagination components, see #58133. Other improvements should be addressed there and I would love to see more focus on that issue. This is a functional change, as this pagination is fundamentally broken from an accessibility perspective. Thanks everyone for feedback and review. |
vcanales
added
[Focus] Accessibility (a11y)
|
Thanks for merging this! |
ellatrix
pushed a commit
that referenced
this pull request
Jun 11, 2024
…sion (#62395) * Showing tooltips for pagination buttons on global styles * Remove redundant aria-label prop. * Use actual SVG icons. * Adjust buttons size. --------- Co-authored-by: ramonjd <ramonopoly@git.wordpress.org> Co-authored-by: afercia <afercia@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: jasmussen <joen@git.wordpress.org>
ellatrix
pushed a commit
that referenced
this pull request
Jun 11, 2024
…sion (#62395) * Showing tooltips for pagination buttons on global styles * Remove redundant aria-label prop. * Use actual SVG icons. * Adjust buttons size. --------- Co-authored-by: ramonjd <ramonopoly@git.wordpress.org> Co-authored-by: afercia <afercia@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: jasmussen <joen@git.wordpress.org>
patil-vipul
pushed a commit
to patil-vipul/gutenberg
that referenced
this pull request
Jun 17, 2024
…sion (WordPress#62395) * Showing tooltips for pagination buttons on global styles * Remove redundant aria-label prop. * Use actual SVG icons. * Adjust buttons size. --------- Co-authored-by: ramonjd <ramonopoly@git.wordpress.org> Co-authored-by: afercia <afercia@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: jasmussen <joen@git.wordpress.org>
ellatrix
removed
the
Backport to WP 6.7 Beta/RC
|
This was cherry-picked to the wp/6.6 branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Maybe resolves #62283
Adds tooltips to pagination buttons for Global Styles revisions.
Why?
To expose the button name via tooltip.
How?
Using the
showTooltipprop on the Button component.Testing Instructions
Screenshots or screencast
2024-06-07.15.10.41.mp4