Fix: Don't allow synced patterns to be inserted on shuffling. #62422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +20 B (0%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
talldan
added
the
[Feature] Patterns
talldan
approved these changes
Jun 19, 2024
jorgefilipecosta
deleted the
fix/dont-allow-synced-patterns-on-the-shufling
branch
ellatrix
pushed a commit
that referenced
this pull request
Jun 25, 2024
Co-authored-by: jorgefilipecosta <jorgefilipecosta@git.wordpress.org> Co-authored-by: talldan <talldanwp@git.wordpress.org> Co-authored-by: richtabor <richtabor@git.wordpress.org> Co-authored-by: ndiego <ndiego@git.wordpress.org>
|
I just cherry-picked this PR to the wp/6.6-rc-1 branch to get it included in the next release: e03c372 |
ellatrix
added
Backported to WP Core
ellatrix
pushed a commit
that referenced
this pull request
Jun 25, 2024
Co-authored-by: jorgefilipecosta <jorgefilipecosta@git.wordpress.org> Co-authored-by: talldan <talldanwp@git.wordpress.org> Co-authored-by: richtabor <richtabor@git.wordpress.org> Co-authored-by: ndiego <ndiego@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #62294
Currently, the pattern shuffle inserts synced patterns as unsynced. This PR fixes the issue by applying the suggestion by @talldan, of not allowing to shuffle to a synced pattern.
Testing Instructions
With the 2024 theme I verified there are originally 2 patterns on the testimonials category.
I created two duplicates of the "Annie Steiner CEO, Greenprint" patterns one that is synced and made the text of the pattern say sync and one that is unsync and made the text of the pattern say unsync.
I added a testimonial pattern and verified the pattern shuffle switches between the two patterns that come with the team and the unsync pattern I created, but never shuffles to the sync patterns.