Use wordmarks dangit (GitHub, JavaScript) #62459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterwilsoncc
requested review from
dmsnell,
spacedmonkey,
desrosj,
ntwb,
nerrad,
ajitbohra,
ryanwelcher,
juanmaguitar,
fabiankaegy and
ndiego
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress. If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core GitHub repository soon after this pull request is merged. If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack. Thank you! ❤️ View changed files❔ lib/README.md ❔ lib/compat/wordpress-6.5/html-api/class-gutenberg-html-tag-processor-6-5.php |
peterwilsoncc
added
the
[Type] Code Quality
|
Size Change: 0 B Total Size: 1.76 MB ℹ️ View Unchanged
|
|
Flaky tests detected in 44d1e7a. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/9473548396
|
|
It would be great if we could add some automation to these spell-checking tasks. |
🤔 |
dmsnell
reviewed
Jun 11, 2024
| * style of including Javascript inside of HTML comments to avoid accidentally | ||
| * closing the SCRIPT from inside a Javascript string. E.g. `console.log( '</script>' )`. | ||
| * style of including JavaScript inside of HTML comments to avoid accidentally | ||
| * closing the SCRIPT from inside a JavaScript string. E.g. `console.log( '</script>' )`. |
There was a problem hiding this comment.
This is backported code, and will disappear once WordPress 6.7 is shipped. It may not be worth introducing the divergence from Core and these "built assets." In other words, this is akin to modifying the contents of dependencies inside node_modules. Just wanted to point this out, as it has and can cause confusion when the code is different than in Core for the given version, beyond the Gutenberg_ prefix naming.
There was a problem hiding this comment.
@dmsnell I never know which order I should update compat code. I've pushed the equivalent branch to WP-Dev with the goal of getting it in to WP 6.6 to update the developer docs on wp.org. See WordPress/wordpress-develop#6785
peterwilsoncc
added
[Type] Developer Documentation
github-actions
bot
removed
the
props-bot
|
As I didn't change any symbols to avoid the risk of introducing bugs, I've change the type of this to developer docs. As many of the typos fixed in this ticket are reflected on developer.wordpress.org, I'll mark it or backport to the 6.6 branch. cc @ellatrix |
peterwilsoncc
added
the
Backport to WP 6.7 Beta/RC
patil-vipul
pushed a commit
to patil-vipul/gutenberg
that referenced
this pull request
Jun 17, 2024
…). Fixes documentation and comment references to capitalize the words in accordance with the wordmarks. No symbols have been renamed to avoid the risk of introducing bugs in case sensitive interpreters. See [WP#60699](https://core.trac.wordpress.org/ticket/60699) Co-authored-by: peterwilsoncc <peterwilsoncc@git.wordpress.org> Co-authored-by: fabiankaegy <fabiankaegy@git.wordpress.org> Co-authored-by: dmsnell <dmsnell@git.wordpress.org> Co-authored-by: juanmaguitar <juanmaguitar@git.wordpress.org>
ellatrix
pushed a commit
that referenced
this pull request
Jun 18, 2024
Fixes documentation and comment references to capitalize the words in accordance with the wordmarks. No symbols have been renamed to avoid the risk of introducing bugs in case sensitive interpreters. See [WP#60699](https://core.trac.wordpress.org/ticket/60699) Co-authored-by: peterwilsoncc <peterwilsoncc@git.wordpress.org> Co-authored-by: fabiankaegy <fabiankaegy@git.wordpress.org> Co-authored-by: dmsnell <dmsnell@git.wordpress.org> Co-authored-by: juanmaguitar <juanmaguitar@git.wordpress.org>
ellatrix
pushed a commit
that referenced
this pull request
Jun 18, 2024
Fixes documentation and comment references to capitalize the words in accordance with the wordmarks. No symbols have been renamed to avoid the risk of introducing bugs in case sensitive interpreters. See [WP#60699](https://core.trac.wordpress.org/ticket/60699) Co-authored-by: peterwilsoncc <peterwilsoncc@git.wordpress.org> Co-authored-by: fabiankaegy <fabiankaegy@git.wordpress.org> Co-authored-by: dmsnell <dmsnell@git.wordpress.org> Co-authored-by: juanmaguitar <juanmaguitar@git.wordpress.org>
|
I just cherry-picked this PR to the wp/6.6-beta-3 branch to get it included in the next release: 838f409 |
ellatrix
added
Backported to WP Core
ellatrix
pushed a commit
that referenced
this pull request
Jun 18, 2024
Fixes documentation and comment references to capitalize the words in accordance with the wordmarks. No symbols have been renamed to avoid the risk of introducing bugs in case sensitive interpreters. See [WP#60699](https://core.trac.wordpress.org/ticket/60699) Co-authored-by: peterwilsoncc <peterwilsoncc@git.wordpress.org> Co-authored-by: fabiankaegy <fabiankaegy@git.wordpress.org> Co-authored-by: dmsnell <dmsnell@git.wordpress.org> Co-authored-by: juanmaguitar <juanmaguitar@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Replaces Github with GitHub in various comments
Replaces Javascript with JavaScript in various comments
WP-Dev ticket: WP#60699 (6.6 docs improvements)
WP-Dev PR: WordPress/wordpress-develop#6785
Why?
If Wordpress and by extension GutenBerg is going to worry about word-marks, it should do so consistently
How?
Manual review after a search.
No code changes as I didn't want to break anything that's case sensitive.
Testing Instructions
Please review the PR and make sure I haven't changed the name of any symbols.
Testing Instructions for Keyboard
Screenshots or screencast