Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve performance of compute_style_properties method. #62522

Merged
merged 3 commits into from
Jun 24, 2024

Commits on Jun 12, 2024

  1. Improve performance of compute_style_properties method.

    Improve logic in compute_style_properties to improve performance. This commit fixes a number of performance issues including.
    
    - Expensive repeated call to `str_starts_with`.
    - Return easy if not array.
    - Repeated call to `strlen`.
    - Move call to `get_property_value` where it is needed.
    - Move call to implode to after empty check.
    jonnynews committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    ac4a7eb View commit details
    Browse the repository at this point in the history
  2. Fix lint.

    jonnynews committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    82f479f View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2024

  1. Apply suggestions from code review

    Co-authored-by: Joe McGill <801097+joemcgill@users.noreply.github.com>
    spacedmonkey and joemcgill authored Jun 14, 2024
    Configuration menu
    Copy the full SHA
    eca89a5 View commit details
    Browse the repository at this point in the history