Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue of HTML entities rendering in command menu #62606

Merged
merged 9 commits into from
Jun 27, 2024
Merged

Fix issue of HTML entities rendering in command menu #62606

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
c6316c1
Fix issue of HTML entities rendering in command menu
amitraj2203 Jun 16, 2024
5e72a8e
Merge branch 'trunk' of github.com:WordPress/gutenberg into fix/issue…
amitraj2203 Jun 17, 2024
49c0d84
Update link to API in block-editor README.md
amitraj2203 Jun 18, 2024
ef03cc3
Merge branch 'trunk' of github.com:WordPress/gutenberg into fix/block…
amitraj2203 Jun 19, 2024
304cf05
Merge branch 'fix/block-editor-docs-links' of github.com:WordPress/gu…
amitraj2203 Jun 19, 2024
303b8c8
Undo previous changes
amitraj2203 Jun 19, 2024
1e2ac81
Fix issue of HTML entities rendering in command menu
amitraj2203 Jun 19, 2024
a8cb039
Add @wordpress/html-entities dependency in packages/core-commands
amitraj2203 Jun 20, 2024
11ce7d4
Merge branch 'trunk' of github.com:WordPress/gutenberg into fix/issue…
amitraj2203 Jun 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions packages/core-commands/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@
"@wordpress/core-data": "file:../core-data",
"@wordpress/data": "file:../data",
"@wordpress/element": "file:../element",
"@wordpress/html-entities": "file:../html-entities",
amitraj2203 marked this conversation as resolved.
Show resolved Hide resolved
"@wordpress/i18n": "file:../i18n",
"@wordpress/icons": "file:../icons",
"@wordpress/private-apis": "file:../private-apis",
Expand Down
3 changes: 2 additions & 1 deletion packages/core-commands/src/site-editor-navigation-commands.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ import {
import { privateApis as routerPrivateApis } from '@wordpress/router';
import { addQueryArgs, getPath } from '@wordpress/url';
import { useDebounce } from '@wordpress/compose';
import { decodeEntities } from '@wordpress/html-entities';

/**
* Internal dependencies
Expand Down Expand Up @@ -93,7 +94,7 @@ const getNavigationCommandLoaderPerPostType = ( postType ) =>
name: postType + '-' + record.id,
searchLabel: record.title?.rendered + ' ' + record.id,
label: record.title?.rendered
? record.title?.rendered
? decodeEntities( record.title?.rendered )
: __( '(no title)' ),
icon: icons[ postType ],
};
Expand Down
Loading