Convert to blocks: upgrade and remove spans if possible #62659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellatrix
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +93 B (+0.01%) Total Size: 1.76 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in dcc35e8. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/9567502817
|
saulyz
approved these changes
Jun 18, 2024
saulyz
approved these changes
Jul 9, 2024
saulyz
approved these changes
Jul 9, 2024
ellatrix
commented
Jul 10, 2024
| @@ -0,0 +1,25 @@ | |||
| export default function anchorReducer( node ) { | |||
There was a problem hiding this comment.
|
I've found that list items having spans are not processed well. The conversion results to To handle these cases I've created custom |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
The idea behind "convert to blocks" (compared to past handling) is to preserve content as much as possible. However, at the moment, we are preserving it a bit too much.
strong.em.bshould be converted tostrong.ishould be converted toem.I've separated out the anchor reducer to only run on paste (because it modifies content).
Why?
We have core formats for these, which is a better experience.
Spans that do nothing leads to a bad user experience.
How?
Testing Instructions
I've added an integration test.
Paste this in the code editor.
Switch to visual and click "convert to blocks". There should be no spans.
Testing Instructions for Keyboard
Screenshots or screencast