Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit support for image block height and width #62750

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from
+6 −3
Open

Add unit support for image block height and width #62750

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
91ef647
Add other unit support in width/height control of image block
akasunil Jun 21, 2024
4f72dba
Merge branch 'trunk' of personal.github.com:WordPress/gutenberg into …
akasunil Jun 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions packages/block-library/src/image/image.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -355,15 +355,18 @@ export default function Image( {
);
}

const [ lightboxSetting, availableUnits ] = useSettings(
'lightbox',
'spacing.units'
);

// TODO: Can allow more units after figuring out how they should interact
// with the ResizableBox and ImageEditor components. Calculations later on
// for those components are currently assuming px units.
const dimensionsUnitsOptions = useCustomUnits( {
availableUnits: [ 'px' ],
availableUnits: availableUnits || [ 'px', '%', 'vw', 'em', 'rem' ],
} );

const [ lightboxSetting ] = useSettings( 'lightbox' );

const showLightboxSetting =
// If a block-level override is set, we should give users the option to
// remove that override, even if the lightbox UI is disabled in the settings.
Expand Down
Loading